hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13240) TestAclCommands.testSetfaclValidations fail
Date Thu, 21 Jul 2016 07:57:20 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

John Zhuge updated HADOOP-13240:
--------------------------------
    Attachment: HADOOP-13240.004.patch

Thanks for the review [~jojochuang]! You brought up a valid concern that different test cases
could share the same file on the local file system. In Patch 004 I use JUnit {{TemporaryFolder
rule}} to solve the problem. The rule also cleans up the temp folder after test run.

Wish we could design a similar mechanism when the common file system is an Hadoop file system,
e.g., on MiniDFSCluster.

Patch 004:
* Incorporate review comments

> TestAclCommands.testSetfaclValidations fail
> -------------------------------------------
>
>                 Key: HADOOP-13240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13240
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.4.1, 2.7.1
>         Environment: hadoop 2.4.1,as6.5
>            Reporter: linbao111
>            Assignee: John Zhuge
>            Priority: Minor
>         Attachments: HADOOP-13240.001.patch, HADOOP-13240.002.patch, HADOOP-13240.003.patch,
HADOOP-13240.004.patch
>
>
> mvn test -Djava.net.preferIPv4Stack=true -Dlog4j.rootLogger=DEBUG,console -Dtest=TestAclCommands#testSetfaclValidations
failed with following message:
> -------------------------------------------------------------------------------
> Test set: org.apache.hadoop.fs.shell.TestAclCommands
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.599 sec <<<
FAILURE! - in org.apache.hadoop.fs.shell.TestAclCommands
> testSetfaclValidations(org.apache.hadoop.fs.shell.TestAclCommands)  Time elapsed: 0.534
sec  <<< FAILURE!
> java.lang.AssertionError: setfacl should fail ACL spec missing
>         at org.junit.Assert.fail(Assert.java:93)
>         at org.junit.Assert.assertTrue(Assert.java:43)
>         at org.junit.Assert.assertFalse(Assert.java:68)
>         at org.apache.hadoop.fs.shell.TestAclCommands.testSetfaclValidations(TestAclCommands.java:81)
> i notice from HADOOP-10277,hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/AclEntry.java
code changed
> should hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.javabe
changed to:
> diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
> index b14cd37..463bfcd
> --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
> +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestAclCommands.java
> @@ -80,7 +80,7 @@ public void testSetfaclValidations() throws Exception {
>              "/path" }));
>      assertFalse("setfacl should fail ACL spec missing",
>          0 == runCommand(new String[] { "-setfacl", "-m",
> -            "", "/path" }));
> +            ":", "/path" }));
>    }
>  
>    @Test



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message