hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13073) RawLocalFileSystem does not react on changing umask
Date Thu, 14 Jul 2016 09:17:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376645#comment-15376645
] 

Andras Bokor commented on HADOOP-13073:
---------------------------------------

Note for the patch:
I had to modify {{testLocalFSDirsetPermission}} as well because it runs after my new test.
My test sets {{FS_PERMISSIONS_UMASK_KEY}} to 022.
{{testLocalFSDirsetPermission}} tries to use 044. The old code creates a new {{Configuration}}
and set the umask to 044 then gets the localfs with that config. But in fact under the hood
the new {{Configuration}} object will be thrown and we get the localfs from cache (with umask
022).
When we get filesystem from cache we use the config object as key but actually the config
object is not used in Key's constructor. Please check {{Key(URI uri, Configuration conf, long
unique) throws IOException {}} method in {{FileSystem.java}}.
That is why I had to modify that testcase too.
This is very misleading and it is easy to use {{FileSystem.getLocal}} on the wrong way (just
like in this test class).

> RawLocalFileSystem does not react on changing umask
> ---------------------------------------------------
>
>                 Key: HADOOP-13073
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13073
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>         Attachments: HADOOP-13073.01.patch, HADOOP-13073.02.patch
>
>
> FileSystemContractBaseTest#testMkdirsWithUmask is changing umask under the filesystem.
RawLocalFileSystem reads the config on startup so it will not react if we change the umask.
> It blocks [HADOOP-7363|https://issues.apache.org/jira/browse/HADOOP-7363] since testMkdirsWithUmask
test will never work with RawLocalFileSystem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message