hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-11361) Fix a race condition in MetricsSourceAdapter.updateJmxCache
Date Wed, 13 Jul 2016 09:22:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374667#comment-15374667
] 

Tsuyoshi Ozawa edited comment on HADOOP-11361 at 7/13/16 9:21 AM:
------------------------------------------------------------------

[~vinayrpet] [~yzhangal] I found that the change of the signature, (in concrete, return type,
of ({{getMetrics(builder, all)}}) breaks other tests - it can cause test failures of TestContainerMetrics
because of type cast failures, although Jenkins could not find it.

To fix the problem, I attach v8 patch without changing signature(return type) of {{getMetrics(builder,
all)}}, and add {{private List<MetricsRecordImpl> getMetrics(builder)}}  as a wrapper
for private call in MetricsSourceAdapter. This hack also preserves backward compatibility.


was (Author: ozawa):
[~vinayrpet] [~yzhangal] I found that the change of the signature, (in concrete return value
here, of ({{getMetrics(, all)}}) breaks other tests - it can cause test failures of TestContainerMetrics
because of type cast failures, although Jenkins could not find it.

To fix the problem, I attach v8 patch without changing signature(return type) of {{getMetrics(builder,
all)}}, and add {{private List<MetricsRecordImpl> getMetrics(builder)}}  as a wrapper
for private call in MetricsSourceAdapter. This hack also preserves backward compatibility.

> Fix a race condition in MetricsSourceAdapter.updateJmxCache
> -----------------------------------------------------------
>
>                 Key: HADOOP-11361
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11361
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.4.1, 2.5.1, 2.6.0
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-111361-003.patch, HADOOP-11361-002.patch, HADOOP-11361-004.patch,
HADOOP-11361-005.patch, HADOOP-11361-005.patch, HADOOP-11361-006.patch, HADOOP-11361-007.patch,
HADOOP-11361.008.patch, HADOOP-11361.patch, HDFS-7487.patch
>
>
> {noformat}
> Caused by: java.lang.NullPointerException
> 	at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateAttrCache(MetricsSourceAdapter.java:247)
> 	at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:177)
> 	at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getAttribute(MetricsSourceAdapter.java:102)
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:647)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message