Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 2 Jun 2016 22:00:00 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12965387.1462477207000.20119.1464904800051@Atlassian.JIRA>
In-Reply-To: <JIRA.12965387.1462477207000@Atlassian.JIRA>
References: <JIRA.12965387.1462477207000@Atlassian.JIRA> <JIRA.12965387.1462477207529@arcas>
Subject: [jira] [Commented] (HADOOP-13105) Support timeouts in LDAP queries
 in LdapGroupsMapping.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Jun 2016 22:00:02 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313164#comment-15313164 ] 

Chris Nauroth commented on HADOOP-13105:
----------------------------------------

The testing approach looks good to me.  Here are a few comments on patch 002.

# I recommend adding a comment on {{AUTHENTICATE_SUCCESS_MSG}} to clarify what is in that binary data.
# It's fun to see the lambdas.  :-)  This does mean it can't apply to branch-2 though.  You'd either need to take away the lambdas for a patch that can apply to both trunk and branch-2, or post separate patches.

> Support timeouts in LDAP queries in LdapGroupsMapping.
> ------------------------------------------------------
>
>                 Key: HADOOP-13105
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13105
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Chris Nauroth
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-13105.000.patch, HADOOP-13105.001.patch, HADOOP-13105.002.patch
>
>
> {{LdapGroupsMapping}} currently does not set timeouts on the LDAP queries.  This can create a risk of a very long/infinite wait on a connection.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org