Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C83A0200B17 for ; Tue, 7 Jun 2016 03:52:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C6D1B160A59; Tue, 7 Jun 2016 01:52:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1D583160A55 for ; Tue, 7 Jun 2016 03:52:21 +0200 (CEST) Received: (qmail 76354 invoked by uid 500); 7 Jun 2016 01:52:21 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 76299 invoked by uid 99); 7 Jun 2016 01:52:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jun 2016 01:52:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 090F62C1F68 for ; Tue, 7 Jun 2016 01:52:21 +0000 (UTC) Date: Tue, 7 Jun 2016 01:52:21 +0000 (UTC) From: "John Zhuge (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13079) Add dfs -ls -q to print ? instead of non-printable characters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 07 Jun 2016 01:52:23 -0000 [ https://issues.apache.org/jira/browse/HADOOP-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317650#comment-15317650 ] John Zhuge commented on HADOOP-13079: ------------------------------------- Thanks [~andrew.wang] for the encouragement! I can see your point about the question mark which is only what is used to hide the non-printable characters. How about renaming it to "hideNonPrintable" which is consistent to help message and the jira title? > Add dfs -ls -q to print ? instead of non-printable characters > ------------------------------------------------------------- > > Key: HADOOP-13079 > URL: https://issues.apache.org/jira/browse/HADOOP-13079 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.6.0 > Reporter: John Zhuge > Assignee: John Zhuge > Attachments: HADOOP-13079.001.patch, HADOOP-13079.002.patch, HADOOP-13079.003.patch > > > Add option {{-q}} to "hdfs dfs -ls" to print non-printable characters as "?". Non-printable characters are defined by [isprint(3)|http://linux.die.net/man/3/isprint] according to the current locale. > Default to {{-q}} behavior on terminal; otherwise, print raw characters. See the difference in these 2 command lines: > * {{hadoop fs -ls /dir}} > * {{hadoop fs -ls /dir | od -c}} > In C, {{isatty(STDOUT_FILENO)}} is used to find out whether the output is a terminal. Since Java doesn't have {{isatty}}, I will use JNI to call C {{isatty()}} because the closest test {{System.console() == null}} does not work in some cases. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org