Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AF939200B11 for ; Mon, 13 Jun 2016 11:23:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AE197160A3C; Mon, 13 Jun 2016 09:23:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2808A160A19 for ; Mon, 13 Jun 2016 11:23:22 +0200 (CEST) Received: (qmail 133 invoked by uid 500); 13 Jun 2016 09:23:21 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 114 invoked by uid 99); 13 Jun 2016 09:23:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jun 2016 09:23:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 113112C1F62 for ; Mon, 13 Jun 2016 09:23:21 +0000 (UTC) Date: Mon, 13 Jun 2016 09:23:21 +0000 (UTC) From: "Akira AJISAKA (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-9427) use jUnit assumptions to skip platform-specific tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Jun 2016 09:23:22 -0000 [ https://issues.apache.org/jira/browse/HADOOP-9427?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D153= 27051#comment-15327051 ]=20 Akira AJISAKA commented on HADOOP-9427: --------------------------------------- Mostly looks good to me. Would you remove {{isWindows}} from TestLocalDirAl= locator.java? > use jUnit assumptions to skip platform-specific tests > ----------------------------------------------------- > > Key: HADOOP-9427 > URL: https://issues.apache.org/jira/browse/HADOOP-9427 > Project: Hadoop Common > Issue Type: Bug > Components: test > Affects Versions: 1-win, 3.0.0-alpha1 > Reporter: Arpit Agarwal > Assignee: Gergely Nov=C3=A1k > Attachments: HADOOP-9427.001.patch, HADOOP-9427.002.patch, HADOOP= -9427.003.patch > > > Certain tests for platform-specific functionality are either executed onl= y on Windows or bypass on Windows using checks like "if (Path.WINDOWS)" e.g= . TestNativeIO. > Prefer using jUnit assumptions instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org