hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13291) Probing stats in DFSOpsCountStatistics/S3AStorageStatistics should be correctly implemented
Date Mon, 20 Jun 2016 23:58:58 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340726#comment-15340726
] 

Hudson commented on HADOOP-13291:
---------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #9990 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9990/])
HADOOP-13291. Probing stats in (jitendra: rev b7c4cf7129768c0312b186dfb94ba1beb891e2f3)
* hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSOpsCountStatistics.java
* hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/TestDFSOpsCountStatistics.java
* hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AStorageStatistics.java


> Probing stats in DFSOpsCountStatistics/S3AStorageStatistics should be correctly implemented
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13291
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13291
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Mingliang Liu
>            Assignee: Mingliang Liu
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-13291.000.patch, HADOOP-13291.001.patch, HADOOP-13291.002.patch
>
>
> To probe a stat in {{StorageStatistics}}, users can use the {{StorageStatistics#isTracked()}}
API. Currently {{DFSOpsCountStatistics}} implements this function wrongly. {{S3AStorageStatistics}}
borrowed the same idea and also has the same error.
> # The {{isTracked()}} is not correctly implemented. I believe this was an omission in
code.
> # {{isTracked()}} checks a stat with operation symbol (instead of enum name). {{getLongStatistics()}}
should return LongStatistics iterators with symbol as name, instead of the enum variable name.
Or else, {{isTracked(getLongStatistics().next().getName());}} returns false. This will lead
to confusion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message