hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13249) RetryInvocationHandler need wrap InterruptedException in IOException when call Thread.sleep
Date Wed, 08 Jun 2016 22:44:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321595#comment-15321595
] 

Jing Zhao commented on HADOOP-13249:
------------------------------------

+1 for throwing {{InterruptedIOException}}. 

Currently if the interruption happens in the {{RetryInvocationHandler}} level, the thread
that is making the RPC call (and also is blocked in the RPC call) gets interrupted (instead
of a worker thread inside of the RPC Client.java). Thus looks like the upper level caller
aims to interrupt the RPC invocation. So I think throwing {{InterruptedIOException}} may be
better than throwing the exception that was being retried.

> RetryInvocationHandler need wrap InterruptedException in IOException when call Thread.sleep
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13249
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13249
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.8.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: HADOOP-13249.000.patch
>
>
> RetryInvocationHandler need wrap InterruptedException in IOException when call Thread.sleep.
Otherwise InterruptedException can't be handled correctly by other components such as HDFS.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message