hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Sasaki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13244) o.a.h.ipc.Server#Server should honor handlerCount when queueSizePerHandler is specified in consturctor
Date Wed, 08 Jun 2016 12:21:21 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kai Sasaki updated HADOOP-13244:
--------------------------------
    Status: Open  (was: Patch Available)

> o.a.h.ipc.Server#Server should honor handlerCount when queueSizePerHandler is specified
in consturctor
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13244
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13244
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>            Reporter: Xiaoyu Yao
>            Assignee: Kai Sasaki
>            Priority: Minor
>         Attachments: HADOOP-13244.01.patch
>
>
> In the code below,  {{this.maxQueueSize = queueSizePerHandler;}} should be 
> {{ this.maxQueueSize = handlerCount * queueSizePerHandler;}}. Luckily, I search the code
base and found most callers invoke the constructor with queueSizePerHandler=-1. This ticket
is opened to make it correct for the case when queueSizePerHandler is not -1. 
> {code}
> if (queueSizePerHandler != -1) {
>       this.maxQueueSize = queueSizePerHandler;
>     } else {
>       this.maxQueueSize = handlerCount * conf.getInt(
>           CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_KEY,
>           CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_DEFAULT);      
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message