hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13228) Add delegation token to the connection in DelegationTokenAuthenticator
Date Wed, 01 Jun 2016 03:43:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15309189#comment-15309189
] 

Andrew Wang commented on HADOOP-13228:
--------------------------------------

LGTM overall, this change looks nice and tight. Few minor comments about the test:

* I agree with you that the static is a bit gross. A new dummy auth handler looks like a small
amount of code, so would prefer that.
* Some of the new imports are unused
* Is "stabbed" the right word? I think you might mean "added" or "injected" or something.

+1 pending though, thanks for working on this Xiao!

> Add delegation token to the connection in DelegationTokenAuthenticator
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-13228
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13228
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13228.01.patch
>
>
> Following [a comment from another jira|https://issues.apache.org/jira/browse/HADOOP-13155?focusedCommentId=15308715&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15308715],
create this to specifically handle the delegation token renewal/cancellation bug in {{DelegationTokenAuthenticatedURL}}
and {{DelegationTokenAuthenticator}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message