hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaoyu Yao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13189) FairCallQueue makes callQueue larger than the configured capacity.
Date Tue, 07 Jun 2016 06:26:21 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317957#comment-15317957

Xiaoyu Yao commented on HADOOP-13189:

Thanks for the heads up [~arpiagariu]. The code change looks good.  I'm not sure whether the
unit test change is needed as the 2nd parameter of the FairCallQueue constructor is already
based on per queue capacity. I would suggest we test with mock (e.g., mockito) to validate
internal subqueue capacity allocation given different {{ipc.server.handler.queue.size}}.

-    fcq = new FairCallQueue<Schedulable>(2, 5, "ns", conf);
+    fcq = new FairCallQueue<Schedulable>(2, 10, "ns", conf);

> FairCallQueue makes callQueue larger than the configured capacity.
> ------------------------------------------------------------------
>                 Key: HADOOP-13189
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13189
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 2.6.0
>            Reporter: Konstantin Shvachko
>            Assignee: Vinitha Reddy Gankidi
>         Attachments: HADOOP-13189.001.patch
> {{FairCallQueue}} divides {{callQueue}} into multiple (4 by default) sub-queues, with
each sub-queue corresponding to a different level of priority. The constructor for {{FairCallQueue}}
takes the same parameter {{capacity}} as the default CallQueue implementation, and allocates
all its sub-queues of size {{capacity}}. With 4 levels of priority (sub-queues) by default
it results in the total callQueue size 4 times larger than it should be based on the configuration.
> {{capacity}} should be divided by the number of sub-queues at some place.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message