hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-13179) GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe
Date Tue, 14 Jun 2016 10:34:01 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vinayakumar B updated HADOOP-13179:
-----------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 2.8.0
           Status: Resolved  (was: Patch Available)

Committed to trunk, branch-2 and branch-2.8.

Thanks [~honma] for the contribution.
Thanks [~cnauroth] for the suggestions and review.

> GenericOptionsParser is not thread-safe because commons-cli OptionBuilder is not thread-safe
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13179
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13179
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: hongbin ma
>            Assignee: hongbin ma
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-13179-master.patch, HADOOP-13179.001.patch
>
>
> I'm running into similar issues like http://stackoverflow.com/questions/22462665/is-hadoops-toorunner-thread-safe,
the author's observation seem to make sense to me. However when I checked the hadoop github
trunk I found the issue still not fixed.
> Chris Nauroth further investigated this issue, here's his quote: 
> {quote}
> The root cause is that commons-cli OptionBuilder is not thread-safe.
> https://commons.apache.org/proper/commons-cli/apidocs/org/apache/commons/cl
> i/OptionBuilder.html
> According to this issue, commons-cli doesn't plan to change that and
> instead chose to document the lack of thread-safety.
> https://issues.apache.org/jira/browse/CLI-209
> I think we can solve this in Hadoop, probably with a one-line change to
> make GenericOptionsParser#buildGeneralOptions a synchronized method.
> {quote}
> I'll soon upload a patch for this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message