Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9ABE32009C6 for ; Tue, 17 May 2016 00:17:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 996B1160A16; Mon, 16 May 2016 22:17:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0E5B0160A1F for ; Tue, 17 May 2016 00:17:13 +0200 (CEST) Received: (qmail 52762 invoked by uid 500); 16 May 2016 22:17:13 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 52705 invoked by uid 99); 16 May 2016 22:17:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 May 2016 22:17:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 057F42C033A for ; Mon, 16 May 2016 22:17:13 +0000 (UTC) Date: Mon, 16 May 2016 22:17:13 +0000 (UTC) From: "Jing Zhao (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13146) Refactor RetryInvocationHandler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 16 May 2016 22:17:14 -0000 [ https://issues.apache.org/jira/browse/HADOOP-13146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285533#comment-15285533 ] Jing Zhao commented on HADOOP-13146: ------------------------------------ +1 for the latest patch. > Refactor RetryInvocationHandler > ------------------------------- > > Key: HADOOP-13146 > URL: https://issues.apache.org/jira/browse/HADOOP-13146 > Project: Hadoop Common > Issue Type: Improvement > Components: io > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Priority: Minor > Attachments: c13146_20160513.patch, c13146_20160513b.patch, c13146_20160514.patch, c13146_20160514b.patch, c13146_20160516.patch > > > - The exception handling is quite long. It is better to refactor it to a separated method. > - The failover logic and synchronization can be moved to a new inner class. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org