Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2244A200B29 for ; Thu, 26 May 2016 07:29:16 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 214C5160A29; Thu, 26 May 2016 05:29:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6A22E160A2E for ; Thu, 26 May 2016 07:29:15 +0200 (CEST) Received: (qmail 20181 invoked by uid 500); 26 May 2016 05:29:14 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 20148 invoked by uid 99); 26 May 2016 05:29:14 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 May 2016 05:29:14 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7F9D52C1F7E for ; Thu, 26 May 2016 05:29:13 +0000 (UTC) Date: Thu, 26 May 2016 05:29:13 +0000 (UTC) From: "Kai Zheng (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-13010) Refactor raw erasure coders MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 26 May 2016 05:29:16 -0000 [ https://issues.apache.org/jira/browse/HADOOP-13010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301555#comment-15301555 ] Kai Zheng commented on HADOOP-13010: ------------------------------------ Thanks [~cmccabe] for the extensive reviewing! Also thanks [~lirui] for working on a patch update. Committed to trunk. > Refactor raw erasure coders > --------------------------- > > Key: HADOOP-13010 > URL: https://issues.apache.org/jira/browse/HADOOP-13010 > Project: Hadoop Common > Issue Type: Sub-task > Affects Versions: 3.0.0-alpha1 > Reporter: Kai Zheng > Assignee: Kai Zheng > Attachments: HADOOP-13010-v1.patch, HADOOP-13010-v2.patch, HADOOP-13010-v3.patch, HADOOP-13010-v4.patch, HADOOP-13010-v5.patch, HADOOP-13010-v6.patch, HADOOP-13010-v7.patch > > > This will refactor raw erasure coders according to some comments received so far. > * As discussed in HADOOP-11540 and suggested by [~cmccabe], better not to rely class inheritance to reuse the codes, instead they can be moved to some utility. > * Suggested by [~jingzhao] somewhere quite some time ago, better to have a state holder to keep some checking results for later reuse during an encode/decode call. > This would not get rid of some inheritance levels as doing so isn't clear yet for the moment and also incurs big impact. I do wish the end result by this refactoring will make all the levels more clear and easier to follow. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org