Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DF6672009C6 for ; Sun, 1 May 2016 22:43:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DDCDB16098E; Sun, 1 May 2016 22:43:14 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3013C1609AD for ; Sun, 1 May 2016 22:43:14 +0200 (CEST) Received: (qmail 5886 invoked by uid 500); 1 May 2016 20:43:13 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 5875 invoked by uid 99); 1 May 2016 20:43:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 May 2016 20:43:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F2A7C2C1F6C for ; Sun, 1 May 2016 20:43:12 +0000 (UTC) Date: Sun, 1 May 2016 20:43:12 +0000 (UTC) From: "Tsz Wo Nicholas Sze (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12957) Limit the number of outstanding async calls MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 01 May 2016 20:43:15 -0000 [ https://issues.apache.org/jira/browse/HADOOP-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265940#comment-15265940 ] Tsz Wo Nicholas Sze commented on HADOOP-12957: ---------------------------------------------- {quote} The previous format string is fine, but FindBugs just mistakingly thinks '%d\n' as '%n'. Patch v010 is posted to have the change: {code} String errMsg = String.format( "Exceeded limit of max asynchronous calls: %d, " + "please configure %s to adjust it.", CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT, CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_KEY); {code} {quote} The findbugs warning indeed says that we should use "%n" and avoid using "\n" since "%n" is the platform-specific line separator; see http://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html . Anyway, removing it is good. BTW, we should print out the configured value but not the default value, i.e. CommonConfigurationKeys.IPC_CLIENT_ASYNC_CALLS_MAX_DEFAULT should be replaced by maxAsyncCalls. > Limit the number of outstanding async calls > ------------------------------------------- > > Key: HADOOP-12957 > URL: https://issues.apache.org/jira/browse/HADOOP-12957 > Project: Hadoop Common > Issue Type: Improvement > Components: ipc > Reporter: Xiaobing Zhou > Assignee: Xiaobing Zhou > Attachments: HADOOP-12957-HADOOP-12909.000.patch, HADOOP-12957-combo.000.patch, HADOOP-12957.001.patch, HADOOP-12957.002.patch, HADOOP-12957.003.patch, HADOOP-12957.004.patch, HADOOP-12957.005.patch, HADOOP-12957.006.patch, HADOOP-12957.007.patch, HADOOP-12957.008.patch, HADOOP-12957.009.patch, HADOOP-12957.010.patch > > > In async RPC, if the callers don't read replies fast enough, the buffer storing replies could be used up. This is to propose limiting the number of outstanding async calls to eliminate the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org