hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13168) Support Future.get with timeout in ipc async calls
Date Thu, 19 May 2016 20:43:12 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292102#comment-15292102
] 

Tsz Wo Nicholas Sze commented on HADOOP-13168:
----------------------------------------------

Thanks for the comments.

> For doc of AsyncGet#get, would 'When timeout == 0' better be 'When timeout = 0'?

Indeed, == is more appropriate since = means assignmeent in Java.

> @return doc should be added for Util#asyncGetTimeout2WaitTimeout

Will revise the javadoc, although this is just an internal utility method.

> In Util#asyncGetTimeout2WaitTimeout, it returns 1 ms, is it possible to lead to overhead
given huge number of calls? ...

It does not seem to cause any real problem.  For simplicity, let's keep the current code.
 We may change it later if it is indeed a real problem.

> In ipc.Client#call, make #get override has the same signature as AsyncGet#get, ...

The current declaration is better since it throws fewer exceptions.  Same applies to #3.

> If getRpcResponse throws IOException, there's no chance to change done back

When getRpcResponse throws IOException, the call is actually done, although it fails.


> Support Future.get with timeout in ipc async calls
> --------------------------------------------------
>
>                 Key: HADOOP-13168
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13168
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: c13168_20160517.patch, c13168_20160518.patch
>
>
> Currently, the Future returned by ipc async call only support Future.get() but not Future.get(timeout,
unit).  We should support the latter as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message