hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kumar Vavilapalli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13154) S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy & paste of AWS examples
Date Tue, 17 May 2016 00:43:13 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285746#comment-15285746
] 

Vinod Kumar Vavilapalli commented on HADOOP-13154:
--------------------------------------------------

[~steve_l], looks like they've been around for a while. git blame on both these methods point
to the following commit, back to you
{code}
commit 27c4e90efce04e1b1302f668b5eb22412e00d033
Author: Steve Loughran <stevel@apache.org>
Date:   Thu May 12 19:24:20 2016 +0100

    HADOOP-13028 add low level counter metrics for S3A; use in read performance tests. contributed
by: stevel
    patch includes
    HADOOP-12844 Recover when S3A fails on IOException in read()
    HADOOP-13058 S3A FS fails during init against a read-only FS if multipart purge
    HADOOP-13047 S3a Forward seek in stream length to be configurable
{code}

> S3AFileSystem printAmazonServiceException/printAmazonClientException appear copy &
paste of AWS examples
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13154
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13154
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 2.7.2
>            Reporter: Steve Loughran
>            Priority: Blocker
>
> The logging code in {{S3AFileSystem.printAmazonServiceException()}} and {{printAmazonClientException}}
appear to be paste + edits of the example code in  the amazon SDK, such as [http://docs.aws.amazon.com/AmazonS3/latest/dev/ListingObjectKeysUsingJava.html]]
> Either we review the license to validate it, and add credits to the code if compatible,
or we rework. HADOOP-13130 would be the place to do that, as it is changing exception handling
anyway.
> tagging as blocker as it is license related



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message