Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A3E219F89 for ; Thu, 7 Apr 2016 13:25:31 +0000 (UTC) Received: (qmail 900 invoked by uid 500); 7 Apr 2016 13:25:26 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 807 invoked by uid 500); 7 Apr 2016 13:25:26 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 583 invoked by uid 99); 7 Apr 2016 13:25:26 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Apr 2016 13:25:26 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C506C2C1F60 for ; Thu, 7 Apr 2016 13:25:25 +0000 (UTC) Date: Thu, 7 Apr 2016 13:25:25 +0000 (UTC) From: "Steve Loughran (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12994) Specify PositionedReadable, add contract tests, fix problems MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12994?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D15= 230223#comment-15230223 ]=20 Steve Loughran commented on HADOOP-12994: ----------------------------------------- Actually, I will do supports-readfully there's an implicit requirement there =E2=80=94how seeks past EOF are handl= ed=E2=80=94, where even if the FS doesn't support that, readFully is expect= ed to catch and downgrade the exception. > Specify PositionedReadable, add contract tests, fix problems > ------------------------------------------------------------ > > Key: HADOOP-12994 > URL: https://issues.apache.org/jira/browse/HADOOP-12994 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 2.8.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Attachments: HADOOP-12994-001.patch, HADOOP-12994-002.patch > > > Some work on S3a has shown up that there aren't tests catching regression= s in readFully, reviewing the documentation shows that its specification co= uld be improved. > # review the spec > # review the implementations > # add tests (proposed: to the seek contract; streams which support seek s= hould support positioned readable) > # fix code, where it differs significantly from HDFS or LocalFS -- This message was sent by Atlassian JIRA (v6.3.4#6332)