Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73EE518786 for ; Wed, 27 Apr 2016 00:31:13 +0000 (UTC) Received: (qmail 20720 invoked by uid 500); 27 Apr 2016 00:31:13 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 20670 invoked by uid 500); 27 Apr 2016 00:31:13 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 20647 invoked by uid 99); 27 Apr 2016 00:31:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Apr 2016 00:31:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D7D982C1F54 for ; Wed, 27 Apr 2016 00:31:12 +0000 (UTC) Date: Wed, 27 Apr 2016 00:31:12 +0000 (UTC) From: "Kai Zheng (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-12579) Deprecate and remove WriteableRPCEngine MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kai Zheng updated HADOOP-12579: ------------------------------- Attachment: HADOOP-12579-v9.patch Updated the patch to remove the entry for the old engine in the protocol as follows. {code} /** * RpcKind determine the rpcEngine and the serialization of the rpc request + * Note: 1 for RPC_WRITABLE, WritableRpcEngine, obsolete and removed */ enum RpcKindProto { RPC_BUILTIN = 0; // Used for built in calls by tests - RPC_WRITABLE = 1; // Use WritableRpcEngine, the actual usage removed RPC_PROTOCOL_BUFFER = 2; // Use ProtobufRpcEngine } {code} > Deprecate and remove WriteableRPCEngine > --------------------------------------- > > Key: HADOOP-12579 > URL: https://issues.apache.org/jira/browse/HADOOP-12579 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Haohui Mai > Attachments: HADOOP-12579-v1.patch, HADOOP-12579-v3.patch, HADOOP-12579-v4.patch, HADOOP-12579-v5.patch, HADOOP-12579-v6.patch, HADOOP-12579-v7.patch, HADOOP-12579-v8.patch, HADOOP-12579-v9.patch > > > The {{WriteableRPCEninge}} depends on Java's serialization mechanisms for RPC requests. Without proper checks, it has be shown that it can lead to security vulnerabilities such as remote code execution (e.g., COLLECTIONS-580, HADOOP-12577). > The current implementation has migrated from {{WriteableRPCEngine}} to {{ProtobufRPCEngine}} now. This jira proposes to deprecate {{WriteableRPCEngine}} in branch-2 and to remove it in trunk. -- This message was sent by Atlassian JIRA (v6.3.4#6332)