hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12994) Specify PositionedReadable, add contract tests, fix problems
Date Sun, 03 Apr 2016 21:13:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223515#comment-15223515
] 

Steve Loughran commented on HADOOP-12994:
-----------------------------------------

One issue here: currently DfsInputStream's internal {{pread}} method returns -1 on a negative
position, which is then uprated to an EOFException in read(). Other implementations view a
negative offset as an illegal argument.

I'm going to make EOFException the default, as it is consistent with a negative seek(). Implementations
can fail-fast on this state

> Specify PositionedReadable, add contract tests, fix problems
> ------------------------------------------------------------
>
>                 Key: HADOOP-12994
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12994
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>
> Some work on S3a has shown up that there aren't tests catching regressions in readFully,
reviewing the documentation shows that its specification could be improved.
> # review the spec
> # review the implementations
> # add tests (proposed: to the seek contract; streams which support seek should support
positioned readable)
> # fix code, where it differs significantly from HDFS or LocalFS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message