hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12951) Improve documentation on KMS ACLs and delegation tokens
Date Sat, 02 Apr 2016 01:02:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222609#comment-15222609
] 

Andrew Wang commented on HADOOP-12951:
--------------------------------------

This looks great. Only one comment, related to the AuthenticationFilter javadoc. As you say,
the user doc and the javadoc are very very similar. I noticed that the javadoc is still incorrectly
referring to "string" rather than "file".

As a fix, how about we delete the javadoc except for the first paragraph, and add a reference
to the md file? This is a private class so devs can find the md file, and this way we aren't
duplicating the information in two places.

> Improve documentation on KMS ACLs and delegation tokens
> -------------------------------------------------------
>
>                 Key: HADOOP-12951
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12951
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-12951.01.patch, HADOOP-12951.02.patch, HADOOP-12951.03.patch
>
>
> [~andrew.wang] suggested that the current KMS ACL page is not very user-focused, and
hard to come by without reading the code.
> I read the document (and the code), and I agree. So this jira puts more documentation
to explain the current implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message