hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vishwajeet Dusane (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12875) [Azure Data Lake] Support for contract test and unit test cases
Date Tue, 12 Apr 2016 13:17:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237136#comment-15237136

Vishwajeet Dusane commented on HADOOP-12875:

[~cnauroth] - Thanks for the review. 
1. For .gitignore - Should this file be added after the initial checkin ? 
2. Below code is not necessary, i have removed that code.
    System.setProperty("hadoop.home.dir", System.getProperty("user.dir")); 
3. Benchmark test were to get latency of Adl driver alone to finds an overhead adl driver
logic is adding. I have removed those test because that should be a different benchmark suite
altogether and need not be part of this patchset.
4. using {{org.apache.hadoop.util.Time#monotonicNow}} now instead of the {{System#currentTimeMillis}}
5. Throwing {{IllegalStateException}} instead of {{NullPointerException}}, this would be useful
for developer to debug quickly on what had gone wrong. Thanks again for this comment.
6. Created separate class for non contract test cases.

> [Azure Data Lake] Support for contract test and unit test cases
> ---------------------------------------------------------------
>                 Key: HADOOP-12875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12875
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: fs, fs/azure, tools
>            Reporter: Vishwajeet Dusane
>            Assignee: Vishwajeet Dusane
>         Attachments: Hadoop-12875-001.patch, Hadoop-12875-002.patch
> This JIRA describes contract test and unit test cases support for azure data lake file

This message was sent by Atlassian JIRA

View raw message