Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 10 Mar 2016 18:59:40 +0000 (UTC)
From: "Mingliang Liu (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12948714.1457601430000.61156.1457636380754@Atlassian.JIRA>
In-Reply-To: <JIRA.12948714.1457601430000@Atlassian.JIRA>
References: <JIRA.12948714.1457601430000@Atlassian.JIRA>
 <JIRA.12948714.1457601430228@arcas>
Subject: [jira] [Commented] (HADOOP-12912) Add LOG.isDebugEnabled() guard in
 Progress.set method
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189741#comment-15189741 ] 

Mingliang Liu commented on HADOOP-12912:
----------------------------------------

I'm in favor of replacing log4j logger to slf4j here (as we're doing in other classes). Please refer to [HDFS-8971]

I don't quite get the point of performance gain to add a guard here. Adding a guard brings no obvious difference as 1) the debug() parameters are string literal which are immutable. 2) the LOG.debug() should check the log level internally. Would you kindly explain in the description? 

> Add LOG.isDebugEnabled() guard in Progress.set method
> -----------------------------------------------------
>
>                 Key: HADOOP-12912
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12912
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Tsuyoshi Ozawa
>            Assignee: Tsuyoshi Ozawa
>         Attachments: HADOOP-12912.001.patch
>
>


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)