hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Yoder (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12942) hadoop credential commands non-obviously use password of "none"
Date Tue, 22 Mar 2016 00:56:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205487#comment-15205487

Mike Yoder commented on HADOOP-12942:

We could:
This is becoming bigger than the intended scope of this jira. :-)

Add a command that provisions an encrypted master secret to a well-known location in HDFS
We'd have to carefully think through what users would be able to perform this action. And
if something like this could be automated instead. And where that "well-known location" might
be - could it be configured (I think we'd have to). And what about recursion issues if that
location was inside an Encryption Zone? 

Obviously, this approach would require KMS to be in use and a new manual step to provision
a master secret.
I think what you propose is workable, but these new requirements do concern me. We'd also
have to think through what users could perform this action (for this action and for making
the key in the KMS). There are lot of moving parts. Seems like a case for a credential server
(or credential server functionality in the KMS).

Back to the issue in this jira - regardless of the difficulty of handling the credential store
password throughout the entire workflow, I still believe that the credential shell should
ask for that password. It's got to be better than silently using "none" everywhere. And given
that the key store provider has the ability to get the password from a file, it seems like
it would be possible to put the password into a file for basically all use cases.

> hadoop credential commands non-obviously use password of "none"
> ---------------------------------------------------------------
>                 Key: HADOOP-12942
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12942
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>            Reporter: Mike Yoder
> The "hadoop credential create" command, when using a jceks provider, defaults to using
the value of "none" for the password that protects the jceks file.  This is not obvious in
the command or in documentation - to users or to other hadoop developers - and leads to jceks
files that essentially are not protected.
> In this example, I'm adding a credential entry with name of "foo" and a value specified
by the password entered:
> {noformat}
> # hadoop credential create foo -provider localjceks://file/bar.jceks
> Enter password: 
> Enter password again: 
> foo has been successfully created.
> org.apache.hadoop.security.alias.LocalJavaKeyStoreProvider has been updated.
> {noformat}
> However, the password that protects the file bar.jceks is "none", and there is no obvious
way to change that. The practical way of supplying the password at this time is something
akin to
> {noformat}
> HADOOP_CREDSTORE_PASSWORD=credpass hadoop credential create --provider ...
> {noformat}
> That is, stuffing HADOOP_CREDSTORE_PASSWORD into the environment of the command. 
> This is more than a documentation issue. I believe that the password ought to be _required_.
 We have three implementations at this point, the two JavaKeystore ones and the UserCredential.
The latter is "transient" which does not make sense to use in this context. The former need
some sort of password, and it's relatively easy to envision that any non-transient implementation
would need a mechanism by which to protect the store that it's creating.  
> The implementation gets interesting because the password in the AbstractJavaKeyStoreProvider
is determined in the constructor, and changing it after the fact would get messy. So this
probably means that the CredentialProviderFactory should have another factory method like
the first that additionally takes the password, and an additional constructor exist in all
the implementations that takes the password. 
> Then we just ask for the password in getCredentialProvider() and that gets passed down
to via the factory to the implementation. The code does have logic in the factory to try multiple
providers, but I don't really see how multiple providers would be rationaly be used in the
command shell context.
> This issue was brought to light when a user stored credentials for a Sqoop action in
Oozie; upon trying to figure out where the password was coming from we discovered it to be
the default value of "none".

This message was sent by Atlassian JIRA

View raw message