hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12926) lz4.c does not detect 64-bit mode properly
Date Thu, 17 Mar 2016 21:38:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200438#comment-15200438
] 

Chris Nauroth commented on HADOOP-12926:
----------------------------------------

[~alanburlison], thank you for posting the patch.  Personally, I am fine with accepting this
small deviation in our import of LZ4 r123.  From my quick scan of r131, it appears that version
handles 64-bit detection in a way that doesn't rely on the pre-processor detecting what the
build toolchain provides.  I think that means that whenever we resume trying to upgrade to
r131 in issue HADOOP-12572, we won't have to worry about forward-porting this little fix.

I'm pretty sure we have never deviated from upstream though in our import of LZ4.  Before
I commit this, I'd like to make sure others who maintain the native code get a chance to comment.
 [~cmccabe] or [~kihwal], perhaps you would like to comment?

> lz4.c does not detect 64-bit mode properly
> ------------------------------------------
>
>                 Key: HADOOP-12926
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12926
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: native
>    Affects Versions: 2.7.2
>         Environment: All
>            Reporter: Alan Burlison
>            Assignee: Alan Burlison
>         Attachments: HADOOP-12926.001.patch
>
>
> lz4.c should check to see if the _LP64 macro is defined to correctly detect when it is
being built in 64-bit mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message