hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12912) Add LOG.isDebugEnabled() guard in Progress.set method
Date Thu, 10 Mar 2016 18:59:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189741#comment-15189741
] 

Mingliang Liu commented on HADOOP-12912:
----------------------------------------

I'm in favor of replacing log4j logger to slf4j here (as we're doing in other classes). Please
refer to [HDFS-8971]

I don't quite get the point of performance gain to add a guard here. Adding a guard brings
no obvious difference as 1) the debug() parameters are string literal which are immutable.
2) the LOG.debug() should check the log level internally. Would you kindly explain in the
description? 

> Add LOG.isDebugEnabled() guard in Progress.set method
> -----------------------------------------------------
>
>                 Key: HADOOP-12912
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12912
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Tsuyoshi Ozawa
>            Assignee: Tsuyoshi Ozawa
>         Attachments: HADOOP-12912.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message