hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12909) Change ipc.Client to support asynchronous calls
Date Sun, 20 Mar 2016 01:32:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203042#comment-15203042
] 

Tsz Wo Nicholas Sze commented on HADOOP-12909:
----------------------------------------------

> V003 fixed issues you mentioned, ...

[~xiaobingo], thanks for the update.  Some comments on the new patch.
- The patch still has quite a few format changes such as shown below.
{code}
@@ -176,7 +190,7 @@ synchronized ExecutorService refAndGetInstance() {
       
       return clientExecutor;
     }
-    
+
     /**
      * Cleanup Executor on which IPC calls' parameters are sent.
      * If reference counter is zero, this method discards the
{code}
- For the new test, we should reuse the code in TestIPC if it does not require logic changes
in it.  Sorry that I was not clear in my last comment.  For example, we should reuse NetworkTraces
and other static methods by simply removing the "private" declarations in TestIPC.

> Change ipc.Client to support asynchronous calls
> -----------------------------------------------
>
>                 Key: HADOOP-12909
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12909
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: ipc
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Xiaobing Zhou
>         Attachments: HADOOP-12909-HDFS-9924.000.patch, HADOOP-12909-HDFS-9924.001.patch,
HADOOP-12909-HDFS-9924.002.patch, HADOOP-12909-HDFS-9924.003.patch
>
>
> In ipc.Client, the underlying mechanism is already supporting asynchronous calls -- the
calls shares a connection, the call requests are sent using a thread pool and the responses
can be out of order.  Indeed, synchronous call is implemented by invoking wait() in the caller
thread in order to wait for the server response.
> In this JIRA, we change ipc.Client to support asynchronous mode.  In asynchronous mode,
it return once the request has been sent out but not wait for the response from the server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message