hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12909) Change ipc.Client to support asynchronous calls
Date Thu, 17 Mar 2016 19:13:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200187#comment-15200187
] 

Tsz Wo Nicholas Sze commented on HADOOP-12909:
----------------------------------------------

The new patch looks great!  I like the idea of using AbstractFuture since it is also a ListenableFuture.
 Some comments:
- As described in the [AbstractFuture API|http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/util/concurrent/AbstractFuture.html],
we should use set(..) and setException(..) so that other methods such as isDone() will also
work.
- TestIPC is changed  so that TestAsyncIPC can reuse the code.  It is better not to change
TestIPC since we want to make use the existing behaviors still work.  Let's just copy the
code to TestAsyncIPC.
- There are some format changes.  Please revert them.



> Change ipc.Client to support asynchronous calls
> -----------------------------------------------
>
>                 Key: HADOOP-12909
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12909
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: ipc
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Xiaobing Zhou
>         Attachments: HADOOP-12909-HDFS-9924.000.patch, HADOOP-12909-HDFS-9924.001.patch,
HADOOP-12909-HDFS-9924.002.patch
>
>
> In ipc.Client, the underlying mechanism is already supporting asynchronous calls -- the
calls shares a connection, the call requests are sent using a thread pool and the responses
can be out of order.  Indeed, synchronous call is implemented by invoking wait() in the caller
thread in order to wait for the server response.
> In this JIRA, we change ipc.Client to support asynchronous mode.  In asynchronous mode,
it return once the request has been sent out but not wait for the response from the server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message