hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Zhuge (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12908) Make JvmPauseMonitor a singleton
Date Sat, 19 Mar 2016 20:05:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202937#comment-15202937
] 

John Zhuge commented on HADOOP-12908:
-------------------------------------

All test failures seem unrelated to the patch. Let me analyze them below.

h4. hadoop-common
* Failed tests: 
** TestGangliaMetrics.testGangliaMetrics2:139->checkMetrics:165 Mismatch in record count:
 expected:<6> but was:<27>

Possible cause: HADOOP-12588

h4. hadoop-hdfs
* Failed tests: 
** TestEditLog.testBatchedSyncWithClosedLogs:594 logging edit without syncing should do not
affect txid expected:<1> but was:<2>

Possible cause: HDFS-10169

h4. hadoop-yarn
* Failed tests: 
** TestClientRMTokens.testShortCircuitRenewCancelDifferentHostSamePort:316->checkShortCircuitRenewCancel:363
expected:<getProxy> but was:<null>
** TestClientRMTokens.testShortCircuitRenewCancelDifferentHostDifferentPort:327->checkShortCircuitRenewCancel:363
expected:<getProxy> but was:<null>
** TestClientRMTokens.testShortCircuitRenewCancelSameHostDifferentPort:305->checkShortCircuitRenewCancel:363
expected:<getProxy> but was:<null>

* Tests in error: 
** TestClientRMTokens.testShortCircuitRenewCancel:285->checkShortCircuitRenewCancel:353
? NullPointer
** TestClientRMTokens.testShortCircuitRenewCancelWildcardAddress:294->checkShortCircuitRenewCancel:353
? NullPointer
** TestAMAuthorization.testUnauthorizedAccess:281 ? UnknownHost Invalid host name...
** TestAMAuthorization.testUnauthorizedAccess:281 ? UnknownHost Invalid host name...

Possible cause: HADOOP-12687

> Make JvmPauseMonitor a singleton
> --------------------------------
>
>                 Key: HADOOP-12908
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12908
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: John Zhuge
>            Assignee: John Zhuge
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12908-001.patch, HADOOP-12908-002.patch, HADOOP-12908-003.patch
>
>
> Make JvmPauseMonitor a singleton just as JvmMetrics because there is no use case to run
multiple instances per JVM. {{TestMetrics$setPauseMonitor}} becomes obsolete. Initialization
code for various components can be simplified.
> For example, this code segment
> {code}
>     pauseMonitor = new JvmPauseMonitor();
>     addService(pauseMonitor);
>     jm.setPauseMonitor(pauseMonitor);
> {code}
> can be replaced with
> {code}
>     addService(JvmPauseMonitor.getInstance());
> {code}
> And this code segment
> {code}
>       pauseMonitor = new JvmPauseMonitor();
>       pauseMonitor.init(config);
>       pauseMonitor.start();
>       metrics.getJvmMetrics().setPauseMonitor(pauseMonitor);
> {code}
> can be replaced with
> {code}
>       pauseMonitor = JvmPauseMonitor.getInstance();
>       pauseMonitor.init(config);
>       pauseMonitor.start();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message