hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12895) SSLFactory#createSSLSocketFactory exception message is wrong
Date Tue, 08 Mar 2016 21:50:41 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185899#comment-15185899
] 

Andrew Wang commented on HADOOP-12895:
--------------------------------------

LGTM thanks Wei-chiu, committing shortly.

> SSLFactory#createSSLSocketFactory exception message is wrong
> ------------------------------------------------------------
>
>                 Key: HADOOP-12895
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12895
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.2-alpha
>            Reporter: Wei-Chiu Chuang
>            Assignee: Wei-Chiu Chuang
>            Priority: Trivial
>         Attachments: HADOOP-12895.001.patch, HADOOP-12895.002.patch, HADOOP-12895.003.patch
>
>
> If in SERVER model, the following code should throw exception indicating Factory is in
SERVER mode, not in CLIENT mode. Otherwise, it could be confusing.
> {code:title=SSLSocketFactory.java}
> public SSLSocketFactory createSSLSocketFactory()
>     throws GeneralSecurityException, IOException {
>     if (mode != Mode.CLIENT) {
>       throw new IllegalStateException("Factory is in CLIENT mode");
>     }
>     return context.getSocketFactory();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message