hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12857) Rework hadoop-tools-dist
Date Wed, 02 Mar 2016 19:11:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176273#comment-15176273
] 

Chris Nauroth commented on HADOOP-12857:
----------------------------------------

This sounds great overall.  Thanks, [~aw]!

bq. Worst case, it'll be a "copy and rename to HADOOP_CONF_DIR".

Or symlinks should be fine too, right?

bq. I'm leaning towards the latter since that will allow mvn clean to work in hadoop-dist
in an expected way, since there won't be a hidden dependency on hadoop-tools having been run
before the mvn package.

Yes, agreed.

bq. distch, distcp, archive-logs, etc, are extremely problematic.

Would it make sense to leave these alone as special cases for now and defer improving them
to a separate patch?  I think the primary benefit of this proposal is improved manageability
of the truly optional components.

As far as managing the work, I agree with ruling out option 2 (multiple patches).  Since this
will be all-or-nothing, I'd prefer not to put trunk into a strange intermediate state.  If
you anticipate this is really going to be too big to review at once, then a feature branch
would give us flexibility to allow those intermediate states while work continues.

Overall, this doesn't sound so huge that it would warrant a feature branch though, so I'm
in favor of a single patch.  Famous last words...  :-)

> Rework hadoop-tools-dist
> ------------------------
>
>                 Key: HADOOP-12857
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12857
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>
> As hadoop-tools grows bigger and bigger, it's becoming evident that having a single directory
that gets sucked in is starting to become a big burden as the number of tools grows.  Let's
rework this to be smarter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message