hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11540) Raw Reed-Solomon coder using Intel ISA-L library
Date Wed, 16 Mar 2016 18:18:33 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197857#comment-15197857
] 

Colin Patrick McCabe commented on HADOOP-11540:
-----------------------------------------------

To be honest, I feel like having so much use of inheritance makes the code hard to follow.
 That's why I argued that doEncodeByConvertingToDirectBuffers should be in RSUtil.java.

bq. Then I realized for Java coders, a default behavior can be provided and used; for native
coders, we can avoid having it because at the beginning of the encode() call the native coder
can memset the output buffers directly

Why not have the Java function reset the buffers at the beginning as well, then?

> Raw Reed-Solomon coder using Intel ISA-L library
> ------------------------------------------------
>
>                 Key: HADOOP-11540
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11540
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: HDFS-7285
>            Reporter: Zhe Zhang
>            Assignee: Kai Zheng
>         Attachments: HADOOP-11540-initial.patch, HADOOP-11540-v1.patch, HADOOP-11540-v2.patch,
HADOOP-11540-v4.patch, HADOOP-11540-v5.patch, HADOOP-11540-with-11996-codes.patch, Native
Erasure Coder Performance - Intel ISAL-v1.pdf
>
>
> This is to provide RS codec implementation using Intel ISA-L library for encoding and
decoding.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message