Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 25 Feb 2016 20:53:18 +0000 (UTC)
From: "Ravi Prakash (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12911135.1446830586000.148455.1456433598138@Atlassian.JIRA>
In-Reply-To: <JIRA.12911135.1446830586000@Atlassian.JIRA>
References: <JIRA.12911135.1446830586000@Atlassian.JIRA>
 <JIRA.12911135.1446830586309@arcas>
Subject: [jira] [Commented] (HADOOP-12556) KafkaSink jar files are created
 but not copied to target dist
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167856#comment-15167856 ] 

Ravi Prakash commented on HADOOP-12556:
---------------------------------------

Hi Steve! Thanks for your review. Is there a reason you'd be reluctant to add kafka as a dependency to hadoop-tools ? These are the dependencies which would get added
{code}
< [INFO] +- org.apache.hadoop:hadoop-kafka:jar:3.0.0-SNAPSHOT:compile
< [INFO] |  \- org.apache.kafka:kafka_2.10:jar:0.8.2.1:compile
< [INFO] |     +- com.yammer.metrics:metrics-core:jar:2.2.0:compile
< [INFO] |     +- org.scala-lang:scala-library:jar:2.10.4:compile
< [INFO] |     +- org.apache.kafka:kafka-clients:jar:0.8.2.1:compile
< [INFO] |     |  \- net.jpountz.lz4:lz4:jar:1.2.0:compile
< [INFO] |     +- net.sf.jopt-simple:jopt-simple:jar:3.2:compile
< [INFO] |     \- com.101tec:zkclient:jar:0.3:compile
{code}
Are there guidelines for when a dependency is scoped as {{compile}} vs {{provided}}? I thought the reason you [wanted a new submodule|https://issues.apache.org/jira/browse/HADOOP-10949?focusedCommentId=14725921&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14725921] (hadoop-kafka) so that we didn't have to add kafka to the hadoop-common.

I agree that we should try to reduce our dependencies as much as possible, but I don't really see an alternative here. 

> KafkaSink jar files are created but not copied to target dist
> -------------------------------------------------------------
>
>                 Key: HADOOP-12556
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12556
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Babak Behzad
>            Assignee: Babak Behzad
>         Attachments: HADOOP-12556.patch
>
>
> There is a hadoop-kafka artifact missing from hadoop-tools-dist's pom.xml which was causing the compiled Kafka jar files not to be copied to the target dist directory. The new patch adds this in order to complete this fix.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)