hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12769) Hadoop maven plugin for msbuild compilations
Date Tue, 09 Feb 2016 17:43:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139278#comment-15139278
] 

Chris Nauroth commented on HADOOP-12769:
----------------------------------------

bq. However, I believe, making cmake maven plugin support windows might be required.

Yes, {{CompileMojo}} was only implemented for *nix initially.  However, I think we could achieve
what we need by making changes only in {{CompileMojo}} so that it can call either {{make}}
or {{msbuild}}, and then we wouldn't need {{MSBuildMojo}}.  Doing it this way would minimize
code divergence in the pom.xml files for the {{native}} vs. {{native-win}} profiles.

I don't think the {{MSBuildMojo}} logic for checksumming the source to detect changes is necessary.
 The call to {{msbuild}} in hadoop-hdfs-native-client is already very fast if the source hasn't
changed.  The checksum comparison would completely prevent the call to {{msbuild}}, but I
don't think that degree of optimization would save significant time.

> Hadoop maven plugin for msbuild compilations
> --------------------------------------------
>
>                 Key: HADOOP-12769
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12769
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: native
>            Reporter: Vinayakumar B
>            Assignee: Vinayakumar B
>         Attachments: HADOOP-12769-01.patch, HADOOP-12769-02.patch
>
>
> Currently, all windows native libraries generations using msbuild, happens for every
invocation of 'mvn install'
> Idea is to, make this as plugin, and make as incremental.
> i.e. Rebuild only when any of the source is changed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message