hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12772) NetworkTopologyWithNodeGroup.getNodeGroup() can loop infinitely for invalid 'loc' values
Date Fri, 05 Feb 2016 22:35:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135170#comment-15135170
] 

Hudson commented on HADOOP-12772:
---------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #9250 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9250/])
HADOOP-12772. NetworkTopologyWithNodeGroup.getNodeGroup() can loop (kihwal: rev 49e176c29f95c179c0f6b07d4d582e6a771a96bd)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NodeBase.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopologyWithNodeGroup.java
* hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> NetworkTopologyWithNodeGroup.getNodeGroup() can loop infinitely for invalid 'loc' values
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-12772
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12772
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.7.2
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>            Priority: Minor
>             Fix For: 2.7.3
>
>         Attachments: HDFS-9762.001.patch, HDFS-9762.002.patch, HDFS-9762.003.patch
>
>
> Although the DatanodInfo/DataNodeDescriptor object tends to have a non-null, non-empty
value for its network location, the getNodeGroup method does not handle the case if an empty
or a null value is passed and can go on recursively causing StackOverflowError. This is an
improvement to check for such a state and error out if the value is null and set the location
to ROOT or empty string and if the original location is empty. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message