hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12699) TestKMS#testKMSProvider intermittently fails during 'test rollover draining'
Date Sun, 07 Feb 2016 20:45:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136428#comment-15136428
] 

Andrew Wang commented on HADOOP-12699:
--------------------------------------

Overall looks great, I checked again in the code and I agree with you about the KMSClientProvider.
Not sure why that test worked before then.

Building the docs is mentioned in BUILDING.txt, basically you call "mvn clean site -Preleasedocs",
so can try that.

A few review comments:

* We have two kinds of caching, CachingKeyProvider (which caches keys) and EagerKeyGeneratorKPCE
(which caches EEKs). It'd be good to add some introductory text explaining this, before talking
about key caching (covered in the existing text) and EEK caching (the new text). In the content,
it would also be good to say "encryption key" and "EEK" rather than just "key" to differentiate
between the two.
* Nit: "server-side" and "client-side" are hyphenated
* Nit: "following property" -> "following properties"

> TestKMS#testKMSProvider intermittently fails during 'test rollover draining'
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-12699
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12699
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-12699.01.patch, HADOOP-12699.02.patch, HADOOP-12699.03.patch,
HADOOP-12699.04.patch, HADOOP-12699.06.patch, HADOOP-12699.07.patch, HADOOP-12699.08.patch,
HADOOP-12699.09.patch, HADOOP-12699.repro.2, HADOOP-12699.repro.patch
>
>
> I've seen several failures of testKMSProvider, all failed in the following snippet:
> {code}
>         // test rollover draining
>         KeyProviderCryptoExtension kpce = KeyProviderCryptoExtension.
>             createKeyProviderCryptoExtension(kp);
>         .....
>         EncryptedKeyVersion ekv1 = kpce.generateEncryptedKey("k6");
>         kpce.rollNewVersion("k6");
>         EncryptedKeyVersion ekv2 = kpce.generateEncryptedKey("k6");
>         Assert.assertNotEquals(ekv1.getEncryptionKeyVersionName(),
>             ekv2.getEncryptionKeyVersionName());
> {code}
> with error message
> {quote}Values should be different. Actual: k6@0{quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message