hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12672) RPC timeout should not override IPC ping interval
Date Tue, 16 Feb 2016 19:06:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149108#comment-15149108
] 

Arpit Agarwal commented on HADOOP-12672:
----------------------------------------

Hi [~iwasakims], the patch lgtm. One nitpick for readability. Callers of handleTimeout can
increment {{waiting}} since callers know how long the wait was. e.g.
{code}
            waiting += soTimeout;
            handleTimeout(e, waiting);
...
      private void handleTimeout(SocketTimeoutException e, int waiting)
{code}

> RPC timeout should not override IPC ping interval
> -------------------------------------------------
>
>                 Key: HADOOP-12672
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12672
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 2.8.0, 2.7.3, 2.6.4
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>         Attachments: HADOOP-12672.001.patch, HADOOP-12672.002.patch
>
>
> Currently if the value of ipc.client.rpc-timeout.ms is greater than 0, the timeout overrides
the ipc.ping.interval and client will throw exception instead of sending ping when the interval
is passed. RPC timeout should work without effectively disabling IPC ping.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message