hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12712) Fix some cmake plugin and native build warnings
Date Fri, 15 Jan 2016 19:56:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102376#comment-15102376
] 

Andrew Wang commented on HADOOP-12712:
--------------------------------------

Overall LGTM, though please take a look at the Jenkins -1s, seem native build related.

I'm also kind of shocked by the {{extract_values}} change. I guess we have a lucky implicit
return since {{extract_values_delim}} will set EAX and hopefully it bubbles up, but that seems
compiler/optimization-level dependent. I think this is undefined behavior.

Ping [~vvasudev] and [~ashahab] as the original authors, as a heads up on this bug.

> Fix some cmake plugin and native build warnings
> -----------------------------------------------
>
>                 Key: HADOOP-12712
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12712
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-12712.001.patch, HADOOP-12712.002.patch, HADOOP-12712.003.patch
>
>
> Fix some native build warnings



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message