hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12690) Consolidate access of sun.misc.Unsafe
Date Wed, 06 Jan 2016 00:54:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084463#comment-15084463

Kai Zheng commented on HADOOP-12690:

The patch looks nice. Thanks [~djp].
A few minor comments:
1. Maybe we could cache the {{unsafe}} instance in the new utility, so callers won't do the
cache thing themselves?
2. Better to have some comment to explain about the new approach, because without looking
at the discussion in the JIRAs, some one may be not easy to catch why it goes like that.
3. I guess you added {{TestFastByteComparision}} by the way?

> Consolidate access of sun.misc.Unsafe 
> --------------------------------------
>                 Key: HADOOP-12690
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12690
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: HADOOP-12690.patch
> Per discussion in Hadoop-12630 (https://issues.apache.org/jira/browse/HADOOP-12630?focusedCommentId=15082142&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15082142),
we found the access of sun.misc.Unsafe could be problematic for some JVMs in other platforms.
Also, hints from other comments, it is better to consolidate it as a helper/utility method
to shared with several places (FastByteComparisons, NativeIO, ShortCircuitShm). 

This message was sent by Atlassian JIRA

View raw message