hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12662) The build should fail if a -Dbundle option fails
Date Wed, 13 Jan 2016 00:41:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095312#comment-15095312

Kai Zheng commented on HADOOP-12662:

Thanks [~cmccabe] for the review and nice comments!

bq. It seems like this should be named bundle_native_lib or something like that, rather than
Sounds much clearer to use {{bundle_native_lib}} as the checking is just the essential part
of it.

bq. the 'X' construction isn't needed in bash. Suggest using this instead
Ah, see. Thanks for the reminding and sample codes. I just got what [~aw] meant.

bq. try using this instead (note the double equals sign)
Sure. Glad I can be refreshed in my shell aspect.

Will update the patch accordingly.

> The build should fail if a -Dbundle option fails
> ------------------------------------------------
>                 Key: HADOOP-12662
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12662
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-12662-v1.patch, HADOOP-12662-v2.patch, HADOOP-12662-v3.patch,
> Per some discussion with [~cmccabe], it would be good to refine and make it consistent
the behaviors in bundling native libraries when building dist package.
> For all native libraries to bundle, if the bundling option like {{-Dbundle.snappy}} is
specified, then the lib option like {{-Dsnappy.lib}} will be checked and ensured to be there,
but if not, it will then report error and fail the building explicitly.
> {{BUILDING.txt}} would also be updated to explicitly state this behavior.

This message was sent by Atlassian JIRA

View raw message