hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-11505) Various native parts use bswap incorrectly and unportably
Date Wed, 20 Jan 2016 19:23:39 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-11505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109231#comment-15109231
] 

Colin Patrick McCabe commented on HADOOP-11505:
-----------------------------------------------

Keep in mind we no longer use the antrun Maven plugin to run {{cmake}}... since HADOOP-8887,
we have a custom CMake plugin to do that.  It runs {{cmake}} + {{make}} every time (but this
takes a very short amount of time on my machine).  We could potentially optimize it to check
file timestamps, although this is something that {{cmake}} itself also does.

I do not want to convert parts of the build to ant... it would be less maintainable than what
we have, especially for platforms like Windows where the build environment is non-UNIX.

Before we start optimizing, I would like to see a breakdown of how much time each step actually
takes.  Or at least a rough estimate.  My gut feeling is that the {{javah}} step could be
worth optimizing, but I don't have any numbers to justify that yet.  Some of the other native
builds have accumulated cruft like file copies which I didn't have time fix.  Above all, we
should find out which step(s) are leading to rebuilds on things that haven't changed.

> Various native parts use bswap incorrectly and unportably
> ---------------------------------------------------------
>
>                 Key: HADOOP-11505
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11505
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Alan Burlison
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-11505.001.patch, HADOOP-11505.003.patch, HADOOP-11505.004.patch,
HADOOP-11505.005.patch, HADOOP-11505.006.patch, HADOOP-11505.007.patch
>
>
> hadoop-mapreduce-client-nativetask fails to use x86 optimizations in some cases.  Also,
on some alternate, non-x86, non-ARM architectures the generated code is incorrect.  Thanks
to Steve Loughran and Edward Nevill for finding this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message