hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
Date Thu, 14 Jan 2016 19:57:40 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098749#comment-15098749
] 

Colin Patrick McCabe commented on HADOOP-8887:
----------------------------------------------

So, the two issues from the plugin I saw were this deprecation warning:
{code}
[WARNING] /testptch/hadoop/hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java:[207,30]
[deprecation] getExecutionProperties() in MavenSession has been deprecated
[WARNING] /testptch/hadoop/hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java:[225,29]
[deprecation] getExecutionProperties() in MavenSession has been deprecated
{code}

and a complaint about the use of a hard tab in {{TestMojo.java}}.  I opened HADOOP-12712 to
fix these warnings.

Aside from that, we have the usual Jenkins weirdness on one of the test runs.
{code}
java.lang.RuntimeException: Error while running command to get file permissions : ExitCodeException
exitCode=127: /bin/ls: error while loading shared libraries: libdl.so.2: failed to map segment
from shared object: Permission denied
{code}
{{libdl.so.2}} is a Linux system library-- nothing to do with anything in this patch.  Best
guess is that someone ran "apt-get update" concurrently with Jenkins and hosed this particular
unit test.

Does that cover all the issues?

> Use a Maven plugin to build the native code using CMake
> -------------------------------------------------------
>
>                 Key: HADOOP-8887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8887
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 2.9.0
>
>         Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch,
HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch, HADOOP-8887.008.patch,
HADOOP-8887.011.patch, HADOOP-8887.012.patch, HADOOP-8887.013.patch, HADOOP-8887.014.patch
>
>
> Currently, we build the native code using ant-build invocations.  Although this works,
it has some limitations:
> * compiler warning messages are hidden, which can cause people to check in code with
warnings unintentionally
> * there is no framework for running native unit tests; instead, we use ad-hoc constructs
involving shell scripts
> * the antrun code is very platform specific
> * there is no way to run a specific native unit test
> * it's more or less impossible for scripts like test-patch.sh to separate a native test
failing from the build itself failing (no files are created) or to enumerate which native
tests failed.
> Using a native Maven plugin would overcome these limitations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message