hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12663) Remove Hard-Coded Values From FileSystem.java
Date Tue, 22 Dec 2015 12:07:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068024#comment-15068024
] 

Steve Loughran commented on HADOOP-12663:
-----------------------------------------

consider static importing the keys and then refer to them without the prefix

> Remove Hard-Coded Values From FileSystem.java
> ---------------------------------------------
>
>                 Key: HADOOP-12663
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12663
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 2.7.1
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: FileSystem.HADOOP-12663.patch
>
>
> Within FileSystem.java, there is one instance where the global variables "CommonConfigurationKeysPublic.IO_FILE_BUFFER_SIZE_KEY"
and "CommonConfigurationKeysPublic.IO_FILE_BUFFER_SIZE_DEFAULT" were being used, but in all
other instances, their literal values were being used.
> Please find attached a patch to remove use of literal values and instead replace them
with references to the global variables.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message