hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12658) Clear javadoc and check style issues around DomainSocket
Date Wed, 30 Dec 2015 07:45:49 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074744#comment-15074744
] 

Uma Maheswara Rao G commented on HADOOP-12658:
----------------------------------------------

Hi Kai,
Thanks for the patch. 
{code}
+  private static native int connect0(String path) throws IOException;;
{code}
Please remove unnecessary “;"

{code}
  * @param path         The path to connect to.
+   * @throws IOException                  If there was an I/O error
+   *                                      performing the connect
    * @return             The new DomainSocket.
{code}
Please maintain consistent spacing for clean look.

{code}
 /**
   * Receive some FileDescriptor objects from the process on the other side of
  /**
   * Receive some FileDescriptor objects from the process on the other side of
{code}
did not cleanup the code well. 2 lines missed to remove I think. Please check

> Clear javadoc and check style issues around DomainSocket
> --------------------------------------------------------
>
>                 Key: HADOOP-12658
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12658
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>            Priority: Trivial
>         Attachments: HADOOP-12658-v1.patch, HADOOP-12658-v2.patch, HADOOP-12658-v3.patch,
HADOOP-12658-v4.patch
>
>
> It was noticed Javadoc needs minor udpate in {{DomainSocket}}.
> There are some other check style issues around to clear up found when working on HDFS-8562.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message