Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BBB6F18DC0 for ; Tue, 17 Nov 2015 22:56:11 +0000 (UTC) Received: (qmail 44150 invoked by uid 500); 17 Nov 2015 22:56:11 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 44083 invoked by uid 500); 17 Nov 2015 22:56:11 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 44040 invoked by uid 99); 17 Nov 2015 22:56:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 22:56:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 239872C1F6B for ; Tue, 17 Nov 2015 22:56:11 +0000 (UTC) Date: Tue, 17 Nov 2015 22:56:11 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-12567) NPE in SaslRpcServer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated HADOOP-12567: ----------------------------------- Hadoop Flags: Reviewed bq. Fixed. The time is ripe to increase the limit to 100 :P Spoken like a true Hive/HBase dev. I will not reopen the religious debate for Hadoop here though. :-) +1 for patch v01 pending another pre-commit run. > NPE in SaslRpcServer > -------------------- > > Key: HADOOP-12567 > URL: https://issues.apache.org/jira/browse/HADOOP-12567 > Project: Hadoop Common > Issue Type: Task > Affects Versions: 2.7.0, 2.7.1 > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Attachments: HADOOP-12567.01.patch, HADOOP-12567.patch > > > {noformat} > if (LOG.isDebugEnabled()) { > String username = > getIdentifier(authzid, secretManager).getUser().getUserName(); > LOG.debug("SASL server DIGEST-MD5 callback: setting " > + "canonicalized client ID: " + username); > } > {noformat} > Looking at identifier implementations, e.g. AbstractDelegationTokenIdentifier (and others), I can see that getUser method can return null. If debug logging is enabled, this NPEs. > If getUser is not expected to return NULL, it should either be checked and erred upon better here, or the error should be allowed to happen where it would otherwise happen, not in some debug log path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)