Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 257A418869 for ; Wed, 18 Nov 2015 02:46:12 +0000 (UTC) Received: (qmail 77968 invoked by uid 500); 18 Nov 2015 02:46:11 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 77898 invoked by uid 500); 18 Nov 2015 02:46:11 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 77599 invoked by uid 99); 18 Nov 2015 02:46:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Nov 2015 02:46:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 140E82C1F6B for ; Wed, 18 Nov 2015 02:46:11 +0000 (UTC) Date: Wed, 18 Nov 2015 02:46:11 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-12567) NPE in SaslRpcServer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010082#comment-15010082 ] Hudson commented on HADOOP-12567: --------------------------------- SUCCESS: Integrated in Hadoop-Yarn-trunk #1414 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1414/]) HADOOP-12567. NPE in SaslRpcServer. Contributed by Sergey Shelukhin. (cnauroth: rev 7fab5c8cec0d2ab62acf50b7c33351fb69c8c187) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java * hadoop-common-project/hadoop-common/CHANGES.txt > NPE in SaslRpcServer > -------------------- > > Key: HADOOP-12567 > URL: https://issues.apache.org/jira/browse/HADOOP-12567 > Project: Hadoop Common > Issue Type: Task > Affects Versions: 2.7.0, 2.7.1 > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Fix For: 2.8.0 > > Attachments: HADOOP-12567.01.patch, HADOOP-12567.patch > > > {noformat} > if (LOG.isDebugEnabled()) { > String username = > getIdentifier(authzid, secretManager).getUser().getUserName(); > LOG.debug("SASL server DIGEST-MD5 callback: setting " > + "canonicalized client ID: " + username); > } > {noformat} > Looking at identifier implementations, e.g. AbstractDelegationTokenIdentifier (and others), I can see that getUser method can return null. If debug logging is enabled, this NPEs. > If getUser is not expected to return NULL, it should either be checked and erred upon better here, or the error should be allowed to happen where it would otherwise happen, not in some debug log path. -- This message was sent by Atlassian JIRA (v6.3.4#6332)