Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D525818DC6 for ; Mon, 23 Nov 2015 21:23:11 +0000 (UTC) Received: (qmail 90896 invoked by uid 500); 23 Nov 2015 21:23:11 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 90752 invoked by uid 500); 23 Nov 2015 21:23:11 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 90709 invoked by uid 99); 23 Nov 2015 21:23:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Nov 2015 21:23:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0FC552C1F5D for ; Mon, 23 Nov 2015 21:23:11 +0000 (UTC) Date: Mon, 23 Nov 2015 21:23:11 +0000 (UTC) From: "Haohui Mai (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023096#comment-15023096 ] Haohui Mai commented on HADOOP-9822: ------------------------------------ +1 > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor > ----------------------------------------------------------------------------------------------- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.3.0 > Reporter: Tsuyoshi Ozawa > Assignee: Tsuyoshi Ozawa > Priority: Minor > Labels: BB2015-05-TBR > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)