hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-12567) NPE in SaslRpcServer
Date Tue, 17 Nov 2015 22:56:11 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HADOOP-12567:
-----------------------------------
    Hadoop Flags: Reviewed

bq. Fixed. The time is ripe to increase the limit to 100 :P

Spoken like a true Hive/HBase dev.  I will not reopen the religious debate for Hadoop here
though.  :-)

+1 for patch v01 pending another pre-commit run.

> NPE in SaslRpcServer
> --------------------
>
>                 Key: HADOOP-12567
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12567
>             Project: Hadoop Common
>          Issue Type: Task
>    Affects Versions: 2.7.0, 2.7.1
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HADOOP-12567.01.patch, HADOOP-12567.patch
>
>
> {noformat}
> if (LOG.isDebugEnabled()) {
>             String username =
>               getIdentifier(authzid, secretManager).getUser().getUserName();
>             LOG.debug("SASL server DIGEST-MD5 callback: setting "
>                 + "canonicalized client ID: " + username);
>           }
> {noformat}
> Looking at identifier implementations, e.g. AbstractDelegationTokenIdentifier (and others),
I can see that getUser method can return null. If debug logging is enabled, this NPEs.
> If getUser is not expected to return NULL, it should either be checked and erred upon
better here, or the error should be allowed to happen where it would otherwise happen, not
in some debug log path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message