hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12567) NPE in SaslRpcServer
Date Thu, 12 Nov 2015 22:58:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003143#comment-15003143
] 

Mingliang Liu commented on HADOOP-12567:
----------------------------------------

Thanks for working on this. The patch makes sense to me.

> NPE in SaslRpcServer
> --------------------
>
>                 Key: HADOOP-12567
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12567
>             Project: Hadoop Common
>          Issue Type: Task
>    Affects Versions: 2.7.0, 2.7.1
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HADOOP-12567.patch
>
>
> {noformat}
> if (LOG.isDebugEnabled()) {
>             String username =
>               getIdentifier(authzid, secretManager).getUser().getUserName();
>             LOG.debug("SASL server DIGEST-MD5 callback: setting "
>                 + "canonicalized client ID: " + username);
>           }
> {noformat}
> Looking at identifier implementations, e.g. AbstractDelegationTokenIdentifier (and others),
I can see that getUser method can return null. If debug logging is enabled, this NPEs.
> If getUser is not expected to return NULL, it should either be checked and erred upon
better here, or the error should be allowed to happen where it would otherwise happen, not
in some debug log path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message