hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12567) NPE in SaslRpcServer
Date Wed, 18 Nov 2015 02:46:11 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010082#comment-15010082
] 

Hudson commented on HADOOP-12567:
---------------------------------

SUCCESS: Integrated in Hadoop-Yarn-trunk #1414 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1414/])
HADOOP-12567. NPE in SaslRpcServer. Contributed by Sergey Shelukhin. (cnauroth: rev 7fab5c8cec0d2ab62acf50b7c33351fb69c8c187)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcServer.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> NPE in SaslRpcServer
> --------------------
>
>                 Key: HADOOP-12567
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12567
>             Project: Hadoop Common
>          Issue Type: Task
>    Affects Versions: 2.7.0, 2.7.1
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 2.8.0
>
>         Attachments: HADOOP-12567.01.patch, HADOOP-12567.patch
>
>
> {noformat}
> if (LOG.isDebugEnabled()) {
>             String username =
>               getIdentifier(authzid, secretManager).getUser().getUserName();
>             LOG.debug("SASL server DIGEST-MD5 callback: setting "
>                 + "canonicalized client ID: " + username);
>           }
> {noformat}
> Looking at identifier implementations, e.g. AbstractDelegationTokenIdentifier (and others),
I can see that getUser method can return null. If debug logging is enabled, this NPEs.
> If getUser is not expected to return NULL, it should either be checked and erred upon
better here, or the error should be allowed to happen where it would otherwise happen, not
in some debug log path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message